Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard changes #22

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

ilakhtenkov
Copy link
Contributor

@ilakhtenkov ilakhtenkov commented Nov 30, 2022

Resolves #17

The solution includes removal of all values from json that are set to default values (Examples: xPos=0, yPos=0, perSeriesAligner="ALIGN_NONE" etc.). Because this values are not stored on the GCP side. The dashboard view is not changing because of this changes.
After that there are only 2 changes left in the json name and etag, and this are not treated as resource change.

@ilakhtenkov ilakhtenkov force-pushed the feature/fix-dashboard branch 2 times, most recently from 1016974 to d3b352d Compare December 2, 2022 23:04
@ilakhtenkov ilakhtenkov force-pushed the feature/fix-dashboard branch from d3b352d to 5217aa1 Compare December 2, 2022 23:06
@rarsan rarsan self-requested a review December 5, 2022 20:26
@rarsan rarsan merged commit 32e31f4 into GoogleCloudPlatform:main Dec 5, 2022
@ilakhtenkov ilakhtenkov deleted the feature/fix-dashboard branch December 6, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform generates 600 lines of json in plan each time.
2 participants