Applying terraform format to all files #18
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ilakhtenkov
force-pushed
the
feature/fix-formating
branch
from
11ca33b to
cf5b234
Compare
|
Hi @rarsan, @npredey.
Is PR is number 1 from the list. Could you please review and merge. |
|
Thank you @Lakhtenkov-iv for contributing this. I see you already signed the CLA. I appreciate you breaking this down into 3 PRs. I will review all by Mon or Tue. Thanks. |
| @@ -44,29 +35,27 @@ locals { | |||
| dataflow_temporary_gcs_bucket_path = "tmp/" | |||
|
|
|||
| dataflow_splunk_template_gcs_path = "gs://dataflow-templates/${var.dataflow_template_version}/Cloud_PubSub_to_Splunk" | |||
| dataflow_pubsub_template_gcs_path = "gs://dataflow-templates/${var.dataflow_template_version}/Cloud_PubSub_to_Cloud_PubSub" | |||
There was a problem hiding this comment.
This variable is used in the replay pipeline included in replay.tf. The replay pipeline is only deployed to recover undelivered messages as described in this solution guide. Therefore it's commented out by default in the replay.tf file. There are probably better ways to do this, but for now we probably add lint warning ignore around this.
There was a problem hiding this comment.
Sorry I didn't get the point that I need to uncomment the code to deploy. I have brought back variable.
| project_log_sink_name = "${var.dataflow_job_name}-project-log-sink" | ||
| organization_log_sink_name = "${var.dataflow_job_name}-organization-log-sink" |
There was a problem hiding this comment.
Same with this variable which is used in a commented out resource organization_log_sink. Let's add tflint-ignore for now? We can add a terraform variable in subsequent PR to conditionally control creation of the org log sink (in addition to new organization_id TF variable).
| @@ -0,0 +1,13 @@ | |||
| terraform { | |||
There was a problem hiding this comment.
Thanks for adding the providers and versions files.
I don't think I've personally tested these older provider versions though.
Has this been tested with these versions? For example, random version below is about 5 yrs old.
There was a problem hiding this comment.
Yes, you are right we need to bump up all the 3: terraform, google and random provider. I will test. Please don't merge
There was a problem hiding this comment.
Now it is good, I've tested with minimal versions that are defined.
ilakhtenkov
force-pushed
the
feature/fix-formating
branch
from
cf5b234 to
78d18fd
Compare
|
Hi @rarsan. Any feedback on this PR? |
|
Thanks for the fixes! PR merged. |
No description provided.