Further refactoring of magician VCR #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> [upstream:376778b77ae8dfad5208b73d0ddcd257d6c59a16] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
iyabchen
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit d38d677
into
GoogleCloudPlatform:main
4 of 6 checks passed
modular-magician
deleted the
downstream-pr-376778b77ae8dfad5208b73d0ddcd257d6c59a16
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SA_KEYenvironment variable now optional, will add support for other credentials in follow-up PR.Options struct for
UploadLogslogBucketandcassetteBucketmoved into Tester objectsafeToLogmap added, environment variables must be marked as safe to be loggedprNumberparameter forUploadLogsandFetchCassettesis now replaced withopt.Headandhead(headincludesauto-pr-orauto-cl-prefix)Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11647