Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host_error_timeout_seconds field to compute_instance on beta provider #2846

Conversation

modular-magician
Copy link
Collaborator

-Added field to google_compute_instance and google_compute_instance_template
-Added tests
-Added doc changes
-Added data_source support

Do you want me to introduce plan-time validation of this field or should the API handle errors on this field?

Release Note Template for Downstream PRs (will be copied)

compute: added `host_error_timeout_seconds` to `google_compute_instance` (beta)

Derived from GoogleCloudPlatform/magic-modules#11652

…provider (#11652)

Co-authored-by: Nick Elliot <nickelliot@google.com>

[upstream:973809a6e894448e63c8bff820c8fa08c0e59fb5]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner September 23, 2024 20:36
@modular-magician modular-magician requested review from roaks3 and removed request for a team September 23, 2024 20:36
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 58153d4 into GoogleCloudPlatform:main Sep 23, 2024
4 of 6 checks passed
@modular-magician modular-magician deleted the downstream-pr-973809a6e894448e63c8bff820c8fa08c0e59fb5 branch November 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant