fix: Match all whitespace and non-whitespace for Pub/Sub subscription filter validation #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filter validation (#11676) [upstream:1f1fc6f3190c6c9345fa91c1db305a98fac7b357] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
shuyama1
and removed request for
a team
modular-magician
deleted the
downstream-pr-1f1fc6f3190c6c9345fa91c1db305a98fac7b357
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change the regular expression validation for Pub/Sub subscriptions to use
[\s\S]instead of.when matching characters to match both whitespace and non-whitespace characters. Because we allow empty filters (see this issue), having only whitespace characters (which would be matched by this filter) is valid as well. This will not introduce any breaking changes as it only expands the character set for subscription filters.This fixes this issue.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11676