Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Dataflow options in parameters #2648

Conversation

modular-magician
Copy link
Collaborator

This PR throws more descriptive errors when users configure dataflow_flex_template_job or dataflow_job parameters with Dataflow options, as documented: do not configure Dataflow options here in parameters.

dataflow: made provider return more descriptive errors when the `parameters` field of `google_dataflow_flex_template_job` contains Dataflow options

Derived from GoogleCloudPlatform/magic-modules#11153

[upstream:2897e86979b8bdc89a7fe8f9397f469e90685ad9]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner August 9, 2024 23:44
@modular-magician modular-magician requested review from iyabchen and removed request for a team August 9, 2024 23:44
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit c10b300 into GoogleCloudPlatform:main Aug 9, 2024
5 of 6 checks passed
@modular-magician modular-magician deleted the downstream-pr-2897e86979b8bdc89a7fe8f9397f469e90685ad9 branch November 18, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant