Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS_config_first_commit #1845

Conversation

modular-magician
Copy link
Collaborator

Fixes - hashicorp/terraform-provider-google#16355

This PR is to support provisioning kmsConfigs for Google Cloud NetApp Volumes through GCP terraform provider.

`google_netapp_kmsconfig`

Derived from GoogleCloudPlatform/magic-modules#9353

* KMS_config_first_commit

* kmscommit for author change

* Updated label to KeyValueLabels

* kmsconfig_update_key_ring_crypto_key_name

* Fixed issues in resource_netapp_kmsconfig_test.go

* removed roation_period

* changed location to us-west1

* fixed double quotes

* changes_with_labels

* changed location to us-central1
[upstream:08644b8fb4c5d63b13c11283a068f1e132903637]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner January 9, 2024 22:04
@modular-magician modular-magician requested review from roaks3 and removed request for a team January 9, 2024 22:04
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 1750ff7 into GoogleCloudPlatform:main Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant