Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add run.googleapis.com/urls annotation to ignore changes #254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KiyotakaMatsushita
Copy link

Description:

This pull request updates the lifecycle configuration by adding metadata[0].annotations["run.googleapis.com/urls"] to the ignore_changes list. This change ensures that updates to the run.googleapis.com/urls annotation do not trigger unnecessary resource recreations, thereby improving deployment stability and efficiency.

Changes:

Added metadata[0].annotations["run.googleapis.com/urls"] to the ignore_changes list in the lifecycle configuration.

Benefits:

Prevents unnecessary resource recreations due to changes in the run.googleapis.com/urls annotation.
Enhances deployment stability and efficiency.

Copy link

google-cla bot commented Oct 29, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant