Fix deployment pull file path issue #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is tied to newer version of Python, due to behavior change of `urlunsplit`: python/cpython#85110. This causes the `join` util from Spack to behave differently: spack/spack#46453. The fix is essentially a copy from the current head of Spack, for its up-to-date `join` util implementation.
douglasjacobsen
approved these changes
Feb 11, 2025
douglasjacobsen
merged commit c095dfa
into
GoogleCloudPlatform:develop
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tied to newer version of Python, due to behavior change of
urlunsplit: python/cpython#85110. This causes thejoinutil from Spack to behave differently: spack/spack#46453.The fix is essentially a copy from the current head of Spack, for its up-to-date
joinutil implementation.