Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up static methods #837

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Clean up static methods #837

merged 1 commit into from
Jan 22, 2025

Conversation

linsword13
Copy link
Collaborator

  • Convert methods in util.env.Env into module-level methods
  • Remove an unused static method in uploader
  • There are a couple remaining in util/file_cache.py, but those are legitimate and hard to untangle from the nested context manager.

Linting command:

pylint --disable=all --enable=E0213 lib/ramble/ramble/*

@linsword13
Clean up static methods
c22aefc 
* Convert methods in util.env.Env into module-level methods
* Remove an unused static method in uploader
* There are a couple remaining in util/file_cache.py, but those are
  legitimate and hard to untangle from the nested context manager.

Linting command:

```
pylint --disable=all --enable=E0213 lib/ramble/ramble/*
```
@linsword13 linsword13 requested a review from rfbgo January 22, 2025 00:49
@rfbgo rfbgo merged commit 1b0e0bd into GoogleCloudPlatform:develop Jan 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfbgo rfbgo rfbgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linsword13 @rfbgo