Make slurm execute script customizable #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
requested changes
Jan 22, 2025
var/ramble/repos/builtin/workflow_managers/slurm/workflow_manager.py
Outdated
Show resolved
Hide resolved
var/ramble/repos/builtin/workflow_managers/slurm/workflow_manager.py
Outdated
Show resolved
Hide resolved
This is done by making the template source path pointing to a workflow_manager_variable. The major change is around extending `register_template`'s `src_path` prop (renamed from `src_name`) to allow it to point to a user-specified path. Another change is to point the destination of the slurm execute script to `execute_experiment`. The intent is to make the ux similar to workspaces that don't use workflow manager, in that manually changing the rendered `execute_experiment` in the experiment_run_dir takes effect.
This allows other templates (not registered via `register_template`) to be able to use these variables.
linsword13
force-pushed
the
slurm-customize
branch
from
c5e41b6 to
f64c385
Compare
douglasjacobsen
approved these changes
Jan 24, 2025
douglasjacobsen
merged commit d559b7e
into
GoogleCloudPlatform:develop
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by making the template source path pointing to a
workflow_manager_variable.
The major change is around extending
register_template'ssrc_pathprop (renamed from
src_name) to allow it to point to a user-specifiedpath.
Another change related to template rendering is to define
template_render_varsas reserved variables.