Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defend against -1 values for n_nodes (and update examples) #764

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

rfbgo
Copy link
Collaborator

@rfbgo rfbgo commented Nov 12, 2024

No description provided.

Copy link
Collaborator

@douglasjacobsen douglasjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably should have the default ramble.yaml (defined in workpsace.py) updated as well, right?

@rfbgo
Copy link
Collaborator Author

rfbgo commented Nov 14, 2024

I think we probably should have the default ramble.yaml (defined in workpsace.py) updated as well, right?

It actually was by you ~2 months ago, but we missed a few other changes like examples :)

00acbac

@douglasjacobsen
Copy link
Collaborator

Ah, OK! Thanks! :)

@linsword13 linsword13 merged commit fe3cf27 into GoogleCloudPlatform:develop Nov 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants