Update the mod test to not assume the first phase #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] develop from GoogleCloudPlatform:develop
Only assert the `mod_phase` happens before `make_experiments`. Technically there's no assurance that `mod_phase` will be the first phase in the setup pipeline. Some other phases such as `license_includes` could be placed arbitrarily.
douglasjacobsen
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only assert the
mod_phasehappens beforemake_experiments.Technically there's no assurance that
mod_phasewill be the firstphase in the setup pipeline. Some other phases such as
license_includescould be placed arbitrarily.