Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Cloud-build tutorial triggers #647

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Create Cloud-build tutorial triggers #647

merged 3 commits into from
Sep 16, 2024

Conversation

douglasjacobsen
Copy link
Collaborator

This merge adds cloud-build triggers for running through the ramble tutorials, to ensure they function the way they should.

@douglasjacobsen douglasjacobsen added documentation Improvements or additions to documentation testing Modifications to testing labels Sep 13, 2024
dapomeroy
dapomeroy requested changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@dapomeroy dapomeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, as far as I can tell without having specific experience on cloud build triggers. A couple of minor issues.

douglasjacobsen
douglasjacobsen commented Sep 16, 2024
View reviewed changes
Copy link
Collaborator Author

@douglasjacobsen douglasjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments! All done! :)

@dapomeroy dapomeroy merged commit a4fe631 into GoogleCloudPlatform:develop Sep 16, 2024
12 checks passed
@douglasjacobsen douglasjacobsen deleted the tutorial-triggers branch February 7, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapomeroy dapomeroy dapomeroy approved these changes

Assignees

@dapomeroy dapomeroy

Labels
documentation Improvements or additions to documentation testing Modifications to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglasjacobsen @dapomeroy