Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repos used in deployments #645

Conversation

douglasjacobsen
Copy link
Collaborator

This merge updates how repositories are used within deployments.

Previously, when creating a deployment, Ramble would create configuration files to add the deployment into the resulting workspace.

This merge changes this behavior so that the repository is created, but it is added at deployment pull time instead of deployment push time. This allows the path of the deployment respository to be absolute on the remote machine rather than a relative path that hopefully will work on the remote machine.

This commit updates how repositories are used within deployments.

Previously, when creating a deployment, Ramble would create
configuration files to add the deployment into the resulting workspace.

This commit changes this behavior so that the repository is created, but
it is added at deployment pull time instead of deployment push time.
This allows the path of the deployment respository to be absolute on the
remote machine rather than a relative path that hopefully will work on
the remote machine.
Copy link
Collaborator

@linsword13 linsword13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very helpful change, I recalled wanting it when doing the gke PoC!

One minor question in the review.

@linsword13 linsword13 merged commit 3be8aec into GoogleCloudPlatform:develop Sep 13, 2024
12 checks passed
@douglasjacobsen douglasjacobsen deleted the deployment-repositories branch September 13, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants