Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix '--where' experiment index filter on info #642

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

dapomeroy
Copy link
Collaborator

Fixes a bug where filtering using '--where' on the experiment index does not work correctly

@dapomeroy dapomeroy force-pushed the where_filtering branch 2 times, most recently from 86ad1f5 to 60c87ce Compare September 11, 2024 22:12
Fixes a bug where filtering using '--where' on the experiment index does
not work correctly
Copy link
Collaborator

@linsword13 linsword13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Wonder if we can add a test for it?

Adds a test to check for correct indexing using where filter in
workspace info.
@dapomeroy dapomeroy assigned dapomeroy and linsword13 and unassigned dapomeroy Sep 12, 2024
@linsword13 linsword13 merged commit 0e5257d into GoogleCloudPlatform:develop Sep 12, 2024
12 checks passed
Copy link
Collaborator

@douglasjacobsen douglasjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG One small request, but otherwise this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants