-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a run_in_background
option for executables
#573
Add a run_in_background
option for executables
#573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question.
As an aside, is it useful to capture the PID of the backgrounded process, so we can do something like sleep until it's finished?
Yeah good call. I was thinking to have a modifier to achieve that (using an |
Added a modifier doing the wait-for-completion for background jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes! This is awesome.
One small comment, otherwise it LGTM. Feel free to choose between adding the conditional check or adding a comment in the doc string.
635e4d3
into
GoogleCloudPlatform:develop
No description provided.