Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activation support in workspace create #543

Merged

Conversation

linsword13
Copy link
Collaborator

@linsword13 linsword13 commented Jun 28, 2024

I find it a nice convenience.

// Create without -a remains the same
$ ramble workspace create act-test1
==> Created workspace in act-test1
==> You can activate this workspace with:
==>   ramble workspace activate act-test1

$ ramble workspace activate act-test1
$ echo $RAMBLE_WORKSPACE
/usr/local/google/home/linsword/hpc-dev/ramble/var/ramble/workspaces/act-test1

// With -a
$ ramble workspace create act-test2 -a
==> Created and activated workspace in act-test2

$ echo $RAMBLE_WORKSPACE
/usr/local/google/home/linsword/hpc-dev/ramble/var/ramble/workspaces/act-test2

@linsword13 linsword13 marked this pull request as ready for review July 2, 2024 00:29
@douglasjacobsen
Copy link
Collaborator

This doesn't seem to work on my system. Instead of it activating the new workspace, it just prints:

└─▪ ramble workspace create test_workspace_activate -a
ramble workspace activate test_workspace_activate
└─▪

[pull] develop from GoogleCloudPlatform:develop
I find it a nice convenience.

```
// Create without -a remains the same
$ ramble workspace create act-test1
==> Created workspace in act-test1
==> You can activate this workspace with:
==>   ramble workspace activate act-test1

$ ramble workspace activate act-test1
$ echo $RAMBLE_WORKSPACE
/usr/local/google/home/linsword/hpc-dev/ramble/var/ramble/workspaces/act-test1

// With -a
$ ramble workspace create act-test2 -a
==> Created and activated workspace in act-test2

$ echo $RAMBLE_WORKSPACE
/usr/local/google/home/linsword/hpc-dev/ramble/var/ramble/workspaces/act-test2
```

This is a WIP: currently only bash support is in.
@douglasjacobsen douglasjacobsen merged commit f0b695c into GoogleCloudPlatform:develop Jul 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants