Tweak repo add behavior
#538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when doing `ramble repo add <repo-path>`, it won't error out if the repo does not contain all object types. Behavior with the change: * Complains when specified type not found (same as previous) ```sh $ ramble repo create test-repo $ ls test-repo applications modifiers repo.yaml $ rm -r test-repo/modifiers/ $ ramble repo add -t modifiers test-repo ==> Error: Failed to find valid repo with type ObjectTypes.modifiers ``` * Do not complain when no type is specified (changed from previous) ```sh $ ramble repo add test-repo ==> Added applications repo with namespace 'test-repo'. ``` * Complain if no valid repo is found ```sh $ rm -r test-repo/applications/ $ ramble repo add test-repo ==> Error: The given path test-repo is not a valid repo for any object types ```
rfbgo
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when doing
ramble repo add <repo-path>, it won't error out if therepo does not contain all object types.
Behavior with the change: