Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup items #519

Merged
merged 3 commits into from
Jun 1, 2024
Merged

Cleanup items #519

merged 3 commits into from
Jun 1, 2024

Conversation

linsword13
Copy link
Collaborator

@linsword13 linsword13 commented Jun 1, 2024 •
edited
Loading

This includes a few cleanup items:

  • Remove stated support for python2, given that we've dropped six in a previous PR
  • Remove py26 external dep
  • Remove redundant flake8 exemption comment in modifiers. The exemption is now applied via the style cmd
  • Re-raise commandNotFoundError with an error message mentioning "ramble" instead of "spack"

@douglasjacobsen douglasjacobsen merged commit 90490cb into GoogleCloudPlatform:develop Jun 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglasjacobsen douglasjacobsen douglasjacobsen approved these changes

@rfbgo rfbgo Awaiting requested review from rfbgo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linsword13 @douglasjacobsen