Add black code formatter
#515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This heavily models after `spack style`, and includes only `flake8` check currently. The intent is to have a general style check command to allow for adding in more style check tools like `black`. `ramble style` is a replacement of `ramble flake8` as of now. Next step is to add in black formatter support.
Currently this is not enforced in any CI checks yet. Next step is to apply the formatter fix, and then enforce the format check after that. Example usage: ``` // Check with both black and flake8 ramble style // Only check black ramble style -t black // Apply black fix for all relevant files ramble style -t black -a -f ```
douglasjacobsen
requested changes
May 30, 2024
douglasjacobsen
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included:
ramble stylecmd. Currently it supports runningflake8andblackstylecmd will replaceramble flake8in the futureNext step is to run
ramble style -a -t black -fto apply auto-format to all the in-scope files.