Ensure chained experiment definitions are copies of base #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where chained experiment definitions were all references to the base experiment definition. As a result, when an experiment generated the commands for its chained experiments the commands were never allowed to render again. This caused repeat experiments (which clone a base experiment) to have the incorrect execution command (which only referred to the base experiment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixes an issue where chained experiment definitions were all references to the base experiment definition. As a result, when an experiment generated the commands for its chained experiments the commands were never allowed to render again. This caused repeat experiments (which clone a base experiment) to have the incorrect execution command (which only referred to the base experiment).