Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context output format to reduce duplication #454

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

rfbgo
Copy link
Collaborator

@rfbgo rfbgo commented Apr 4, 2024

This is a breaking change for anyone who consumes our output format wrt contexts

This PR makes it so that contexts only use the format string when printing, to reduce how repetitive and annoying to construct the format is.

The new output looks like:

txt

 10   Bytes: 0 (BW) figures of merit:
 11     Bandwidth = 0.00 Mbytes/sec

json

131         {
132           "name": "Bytes: 0 (BW)",
133           "foms": [
134             {
135               "value": "0.00",
136               "units": "Mbytes/sec",
137               "origin": "IntelMpiBenchmarks",
138               "origin_type": "application",
139               "name": "Bandwidth"
140             }
141           ]
142         },

This is also reflected the same way in the upload db

The old formats looked like:

txt

 10   Bytes: bytes (BW) = Bytes: 0 (BW) figures of merit:
 11     Bandwidth = 0.00 Mbytes/sec

json

  "name": "Bytes: bytes (BW) = Bytes: 0 (BW)",
133           "foms": [
134             {
135               "value": "0.00",
136               "units": "Mbytes/sec",
137               "origin": "IntelMpiBenchmarks",
138               "origin_type": "application",
139               "name": "Bandwidth"
140             }
141           ]
142         },

@rfbgo rfbgo requested a review from douglasjacobsen April 4, 2024 16:53
douglasjacobsen
douglasjacobsen previously approved these changes Apr 4, 2024
Copy link
Collaborator

@douglasjacobsen douglasjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once the CI passes

@douglasjacobsen douglasjacobsen merged commit 3b3a6f6 into GoogleCloudPlatform:develop Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants