Add support for modifiers to register phases #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends available experiment statuses to include more options (such as RUNNING). A helper method is added to the application class to make defining new variables easier.
This commit allows the execute pipeline to control the verbosity of logger output.
douglasjacobsen
added
enhancement
This commit adds a test to make sure modifier phases register properly, are executed, and are ordered properly as well.
douglasjacobsen
force-pushed
the
modifier_phases
branch
from
f7ee263 to
78b0229
Compare
rfbgo
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge migrates the
register_phasedirective into the shared_directives language set. This allows modifiers to also register their own phases to manipulate experiment setup / execution / etc.Phases are allowed to specify their order based on other phase names, and will be topologically sorted to create the final phase ordering.