Skip to content

Commit

Permalink
Remove deprecated spack schemas
Browse files Browse the repository at this point in the history
  • Loading branch information
linsword13 committed May 24, 2024
1 parent 21f1f3e commit 7de4373
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 21 deletions.
1 change: 1 addition & 0 deletions lib/ramble/docs/dev_guides/application_dev_guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ directives that are intended to be package manager specific. As an example,
there are directives for Spack defined by:

* :meth:`ramble.language.shared_language.software_spec`
* :meth:`ramble.language.shared_language.define_compiler`
* :meth:`ramble.language.shared_language.required_package`

These provide Ramble with information about how Spack could install and require
Expand Down
19 changes: 0 additions & 19 deletions lib/ramble/ramble/schema/spack.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,12 @@
:lines: 12-
""" # noqa E501

import ramble.schema.variables
import ramble.schema.applications
import ramble.schema.zips

#: Properties for inclusion in other schemas
properties = {
'spack': {
'type': 'object',
'properties': {
'concretized': {
'type': 'boolean',
'default': None
},
'variables': ramble.schema.variables.variables_def,
'zips': ramble.schema.zips.zips_def,
'packages': {
'type': 'object',
'additionalProperties': {
Expand All @@ -41,11 +32,6 @@
'type': 'string',
'default': None,
},
'variables': ramble.schema.variables.variables_def,
'zips': ramble.schema.zips.zips_def,
'matrix': ramble.schema.applications.matrix_def,
'matrices': ramble.schema.applications.matrices_def,
'exclude': ramble.schema.applications.exclude_def,
},
'additionalProperties': False,
'default': {}
Expand All @@ -67,11 +53,6 @@
'items': {'type': 'string'},
'default': []
},
'variables': ramble.schema.variables.variables_def,
'zips': ramble.schema.zips.zips_def,
'matrix': ramble.schema.applications.matrix_def,
'matrices': ramble.schema.applications.matrices_def,
'exclude': ramble.schema.applications.exclude_def,
},
'additionalProperties': False,
'default': {}
Expand Down
1 change: 0 additions & 1 deletion lib/ramble/ramble/test/cmd/workspace.py
Original file line number Diff line number Diff line change
Expand Up @@ -1896,7 +1896,6 @@ def test_workspace_simplify():
variables:
n_nodes: '1'
spack:
concretized: true
packages:
zlib:
spack_spec: zlib
Expand Down
1 change: 0 additions & 1 deletion lib/ramble/ramble/test/end_to_end/env_var_builtin.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ def test_env_var_from_app_only(mutable_config, mutable_mock_workspace_path, mock
variables:
n_nodes: 1
spack:
concretized: true
packages: {}
environments: {}
"""
Expand Down

0 comments on commit 7de4373

Please sign in to comment.