Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Endpoints 1.1 sample #439

Closed
wants to merge 3 commits into from
Closed

Add Endpoints 1.1 sample #439

wants to merge 3 commits into from

Conversation

saicheems
Copy link
Contributor

Updated the sample to use the Endpoints 1.1 Python client with
configuration options for service management and service control.

Updated the sample to use the Endpoints 1.1 Python client with
configuration options for service management and service control.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2016
@saicheems
Copy link
Contributor Author

This is an in progress sample for the 1.1 client - The functions include /echo and /echo/getUserEmail. We're also trying to show off integration with service control and service management via swagger.

Any feedback on the design and how to improve the surface is welcome.


# Endpoints 1.1 uses background threads for caching and reporting to service
# management and service control.
manual_scaling:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. Is there any plans to make this work with auto-scaled modules?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are, I don't have all the details around it, but once I do I'll be sure to test/update this pull.

Maybe @tbetbetbe can offer some more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG.

@theacodes theacodes self-assigned this Aug 4, 2016
@@ -0,0 +1,64 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the flexible endpoints sample, we use yaml for the definition. Is it possible to use yaml here as well or not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible, I think. This swagger is autogenerated from the endpoints service by a new tool. I don't think it has an option to generate yaml, but I can convert it if that's preferred.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's autogenerated don't sweat it.

@theacodes
Copy link
Contributor

I know this goes back on what I said initial, but since this will break a lot of the current docs pages can I recommend that you place this in /appengine/standard/endpoints-v1.1/backend instead of replacing the existing sample?

@saicheems
Copy link
Contributor Author

Done

@saicheems
Copy link
Contributor Author

Redone against master.

@saicheems saicheems closed this Aug 8, 2016
msampathkumar pushed a commit that referenced this pull request Nov 14, 2022
telpirion pushed a commit that referenced this pull request Jan 13, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472561635

Source-Link: googleapis/googleapis@332ecf5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4313d682880fd9d7247291164d4e9d3d5bd9f177
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472561635

Source-Link: googleapis/googleapis@332ecf5

Source-Link: googleapis/googleapis-gen@4313d68
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
telpirion pushed a commit that referenced this pull request Mar 13, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472561635

Source-Link: googleapis/googleapis@332ecf5

Source-Link: googleapis/googleapis-gen@4313d68
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants