Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pub/Sub: update how to test with mock #2555
Pub/Sub: update how to test with mock #2555
Changes from 7 commits
1a85239
1abf3c9
666b6bd
0cccbf8
96c66fe
3acf66a
5eba4fa
83bbf39
475a57d
6617f22
bca6eef
a3b9de3
06d0ce6
3242686
8670eff
ffa76bb
e877d54
6fb596c
85a3d98
9ef38f5
a4d9a26
b4a0120
4fadbfc
fffd0fd
7cf5693
d2afe6a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these
_to_delete()
functions be done with as a module-level fixture teardown?https://docs.pytest.org/en/latest/fixture.html#fixture-finalization-executing-teardown-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to call delete out in
publisher_test.py
because there's atest_delete()
and conflicts with teardown afteryield
. I left this comment earlier for Tim as well: #2555 (comment)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the
eventually_consistent
necessary? Can they be changed in some way to make sure the resources are available by the time the tests are run so we can delete them through the fixtures?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can address this in a different PR?
@eventually_consistent
is used throughout the repo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me