Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organizing some test stuff. #25

Merged
merged 1 commit into from
May 21, 2015

Conversation

theacodes
Copy link
Contributor

  • Bigquery and storage tests extend from common tests.CloudBaseTest.
  • All test resources now live in tests/resources, accessible via self.resources inside of tests.
  • Updated tox to allow testing a single file for dev purposes.

@theacodes
Copy link
Contributor Author

@tmatsuo PTAL

@@ -22,5 +22,5 @@ commands =
cover: --cover-tests --cover-branches --cover-min-percentage=70 \
cover: --cover-inclusive --cover-erase
cover: coveralls
nosetest: nosetests --with-gae
nosetest: nosetests --with-gae []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this [] for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes arguments given to tox into nosetests

* Bigquery and storage tests extend from common tests.CloudBaseTest.
* All test resources now live in tests/resources, accessible via self.resources inside of tests.
* Updated tox to allow testing a single file for dev purposes.
@tmatsuo
Copy link
Contributor

tmatsuo commented May 21, 2015

Because the travis is using secrets, we can not run the tests for pull requests from other repo, even it's coming from googlers. Maybe you can create a pull request from a branch in the same repo next time, so that travis will be able to run the test.

@tmatsuo
Copy link
Contributor

tmatsuo commented May 21, 2015

LGTM

theacodes pushed a commit that referenced this pull request May 21, 2015
Re-organizing some test stuff.
@theacodes theacodes merged commit 2823a5d into GoogleCloudPlatform:master May 21, 2015
m-strzelczyk pushed a commit that referenced this pull request Nov 3, 2022
dandhlee pushed a commit that referenced this pull request Nov 15, 2022
dizcology pushed a commit that referenced this pull request Jun 16, 2023
* chore: add quickstart and test

This PR introduces code for a reservation quickstart, but does not
include the wiring for augmenting kokoro/nox/etc to include it in
testing.  This will be addressed in subsequent changes.

* blacken

* use new samples template

* use samples template

* move imports to sample

* add type hints

* add type hints

* format strings

* revert noxfile

* use env var from noxfile

Co-authored-by: Tim Swast <swast@google.com>
dizcology pushed a commit that referenced this pull request Jul 11, 2023
* chore: add quickstart and test

This PR introduces code for a reservation quickstart, but does not
include the wiring for augmenting kokoro/nox/etc to include it in
testing.  This will be addressed in subsequent changes.

* blacken

* use new samples template

* use samples template

* move imports to sample

* add type hints

* add type hints

* format strings

* revert noxfile

* use env var from noxfile

Co-authored-by: Tim Swast <swast@google.com>
dizcology pushed a commit that referenced this pull request Jul 20, 2023
* chore: add quickstart and test

This PR introduces code for a reservation quickstart, but does not
include the wiring for augmenting kokoro/nox/etc to include it in
testing.  This will be addressed in subsequent changes.

* blacken

* use new samples template

* use samples template

* move imports to sample

* add type hints

* add type hints

* format strings

* revert noxfile

* use env var from noxfile

Co-authored-by: Tim Swast <swast@google.com>
dandhlee pushed a commit that referenced this pull request Jul 24, 2023
* chore: add quickstart and test

This PR introduces code for a reservation quickstart, but does not
include the wiring for augmenting kokoro/nox/etc to include it in
testing.  This will be addressed in subsequent changes.

* blacken

* use new samples template

* use samples template

* move imports to sample

* add type hints

* add type hints

* format strings

* revert noxfile

* use env var from noxfile

Co-authored-by: Tim Swast <swast@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants