Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2 compatibility for print statements #2226

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Python 2 compatibility for print statements #2226

merged 2 commits into from
Jul 17, 2019

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Jun 14, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lint is failing, can you update:

nox > flake8 --show-source --builtin gettext --max-complexity 20 --import-order-style google --exclude .nox,.cache,env,lib,generated_pb2,*_pb2.py,*_pb2_grpc.py --ignore=E121,E123,E126,E226,E24,E704,W503,W504,I100,I201,I202 --application-import-names transcribe_word_time_offsets_test,transcribe_model_selection_test,beta_snippets,beta_snippets_test,transcribe_streaming_test,transcribe_test,transcribe_word_time_offsets,transcribe_streaming,quickstart_test,resources,transcribe_multichannel_test,transcribe_multichannel,transcribe_auto_punctuation,transcribe_async_test,transcribe_enhanced_model,transcribe,transcribe_auto_punctuation_test,quickstart,transcribe_async,transcribe_enhanced_model_test,transcribe_model_selection .
./beta_snippets.py:174:52: E128 continuation line under-indented for visual indent
                                                   word_info.speaker_tag))

You should rewrite line 174 as:

        print(u"word: '{}', speaker_tag: {}".format(
            word_info.word, word_info.speaker_tag))

The hanging indent is causing the issue.

@gguuss
Copy link
Contributor

gguuss commented Jul 17, 2019

LGTM.

@nnegrey nnegrey merged commit 3801103 into master Jul 17, 2019
@nnegrey nnegrey deleted the nnegrey-patch-3 branch July 17, 2019 22:18
busunkim96 pushed a commit to busunkim96/python-speech that referenced this pull request Sep 1, 2020
…form/python-docs-samples#2226)

* Python 2 compatibility for print statements

* Update beta_snippets.py
busunkim96 pushed a commit to googleapis/python-speech that referenced this pull request Sep 3, 2020
…form/python-docs-samples#2226)

* Python 2 compatibility for print statements

* Update beta_snippets.py
telpirion pushed a commit that referenced this pull request Jan 13, 2023
* Python 2 compatibility for print statements

* Update beta_snippets.py
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
* Python 2 compatibility for print statements

* Update beta_snippets.py
telpirion pushed a commit that referenced this pull request Mar 13, 2023
* Python 2 compatibility for print statements

* Update beta_snippets.py
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
…form/python-docs-samples#2226)

* Python 2 compatibility for print statements

* Update beta_snippets.py
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
…form/python-docs-samples#2226)

* Python 2 compatibility for print statements

* Update beta_snippets.py
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 18, 2023
…form/python-docs-samples#2226)

* Python 2 compatibility for print statements

* Update beta_snippets.py
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 22, 2023
…form/python-docs-samples#2226)

* Python 2 compatibility for print statements

* Update beta_snippets.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants