Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): Add Kafka to Dataflow snippet #12013

Conversation

VeronicaWasson
Copy link
Contributor

@VeronicaWasson VeronicaWasson commented Jul 8, 2024

Description

Adds a snippet that shows how to write messages to Pub/Sub from Dataflow.

Bug: b/350789182
Doc bug: b/342015050

Checklist

@VeronicaWasson VeronicaWasson requested review from a team as code owners July 8, 2024 20:51
Copy link

snippet-bot bot commented Jul 8, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 8, 2024
@VeronicaWasson VeronicaWasson force-pushed the dataflow_read_kafka_snippet branch from 9cd2192 to a6f1e0c Compare July 8, 2024 21:03
@VeronicaWasson VeronicaWasson marked this pull request as draft July 8, 2024 21:40
@VeronicaWasson VeronicaWasson force-pushed the dataflow_read_kafka_snippet branch from 6356688 to b4f0958 Compare July 23, 2024 16:55
@VeronicaWasson VeronicaWasson marked this pull request as ready for review July 23, 2024 17:05
@iennae iennae assigned briandorsey and unassigned nicain Aug 2, 2024
dataflow/snippets/read_kafka.py Outdated Show resolved Hide resolved
dataflow/snippets/Dockerfile Outdated Show resolved Hide resolved
@@ -32,6 +33,9 @@ def setup_and_teardown() -> None:
yield
finally:
bucket.delete(force=True)
# Ensure that PipelineOptions subclasses have been cleaned up between tests
# See https://github.com/apache/beam/issues/18197
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@davidcavazos
Copy link
Contributor

Looks like the linter is configured to ignore "self" type annotations, but not "cls".

@davidcavazos
Copy link
Contributor

Updating linter rules on #12428

@davidcavazos davidcavazos merged commit ffa16d8 into GoogleCloudPlatform:main Aug 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants