Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discoveryengine): Update the samples after GA Launch #10635

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

holtskinner
Copy link
Contributor

@holtskinner holtskinner commented Sep 19, 2023

  • Add API Endpoint to Samples
  • Change search_engine_id to data_store_id

Description

Fixes Internal ticket b/300400448

- Change `search_engine_id` to `data_store_id`
@holtskinner holtskinner requested review from a team as code owners September 19, 2023 20:30
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: discoveryengine Issues related to the Discovery Engine API API. labels Sep 19, 2023
- Use correct client (copy/paste mishap)
- Remove erroneous import of annotation
@holtskinner holtskinner added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 19, 2023
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 19, 2023
@msampathkumar msampathkumar changed the title fix: Updates to Vertex AI Search samples after GA Launch fix(vertex-ai): Update the samples after GA Launch Sep 21, 2023
@holtskinner holtskinner changed the title fix(vertex-ai): Update the samples after GA Launch fix(discoveryengine): Update the samples after GA Launch Sep 22, 2023
@holtskinner holtskinner merged commit 7368358 into main Sep 29, 2023
@holtskinner holtskinner deleted the vertexaisearch branch September 29, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: discoveryengine Issues related to the Discovery Engine API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants