Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable_word_time_offsets=False to a few examples, and added enable_wor… #1046

Conversation

dlaqab
Copy link

@dlaqab dlaqab commented Aug 1, 2017

Added enable_word_time_offsets=True to local file version of transcribe_async
Added enable_word_time_offsets=False to other recognize samples (except streaming)

…d_time_offsets=True to local file verison of transcribe_async
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 1, 2017
@dlaqab
Copy link
Author

dlaqab commented Aug 1, 2017

I am covered by employment agreement

@theacodes
Copy link
Contributor

@dlaqab you need to register your github username at go/github, and make sure your @google.com address is associated with your github profile.

@@ -46,7 +46,8 @@ def run_quickstart():
config = types.RecognitionConfig(
encoding=enums.RecognitionConfig.AudioEncoding.LINEAR16,
sample_rate_hertz=16000,
language_code='en-US')
language_code='en-US',
enable_word_time_offsets=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this defaults to false, then we should just leave it out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeing with @jonparrott on this: This is definitely something we want to make clear in the API/client library reference, but adding this in the sample codes would make the API seem harder to use than it actually is (note that the other parameters encoding, langauge_code, and sample_rate_hertz are all required, but enable_word_time_offsets is optional and defaults to false).

What are some possible use case scenarios where not showing enable_word_time_offsets=False could cause friction for the users?

@dlaqab
Copy link
Author

dlaqab commented Aug 2, 2017

@jonparrott thanks for the pointer - Done

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 2, 2017
@beccasaurus beccasaurus self-requested a review August 4, 2017 04:01
@beccasaurus
Copy link
Contributor

The enable_word_time_offsets=False parameter in these samples is extraneous to the task these samples are intended to demonstrate. Closing.

@beccasaurus beccasaurus closed this Aug 4, 2017
@beccasaurus
Copy link
Contributor

beccasaurus commented Aug 4, 2017

Note: samples which demonstrate Enable Word Time Offsets were added to python-docs-samples in #1050

@dlaqab dlaqab deleted the dalaqab_enableWordTimeOffsets_examples branch July 24, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants