Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: unreliable gpg --recv-keys command #4162

Closed
tmatsuo opened this issue Jun 25, 2020 · 2 comments · Fixed by #4171
Closed

testing: unreliable gpg --recv-keys command #4162

tmatsuo opened this issue Jun 25, 2020 · 2 comments · Fixed by #4171
Assignees
@tmatsuo
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Jun 25, 2020

In .kokoro/docker/Dockerfile, we verify Python source code tarball with gpg command. gpg --recv-keys often fails to fetch some keys. In that case the command itself returns 0, but after all the script will fail when it tries to verify the corresponding Python tarball.

Maybe we can introduce another script for retrying the given command few times and receive the key one by one.
@tmatsuo tmatsuo self-assigned this Jun 25, 2020
@tmatsuo tmatsuo added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 25, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jun 25, 2020 •
edited
Loading

Happened on #4160

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jun 25, 2020

Or maybe we can have the public keys in the repo.

tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Jun 25, 2020
testing: reliablly fetch gpg keys
42cad39 
fixes GoogleCloudPlatform#4162
@tmatsuo tmatsuo mentioned this issue Jun 25, 2020
Merged
tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Jun 26, 2020
testing: reliablly fetch gpg keys
7634c33 
fixes GoogleCloudPlatform#4162
tmatsuo pushed a commit that referenced this issue Jun 26, 2020
testing: reliablly fetch gpg keys (#4171)
5447190 
* testing: reliablly fetch gpg keys

fixes #4162

* fix for trampoline_v2 2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmatsuo tmatsuo

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testing: reliablly fetch gpg keys tmatsuo/python-docs-samples
1 participant
@tmatsuo