Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spanner] bug: sample code is waiting for the backup operations forever. #3471

Closed
tmatsuo opened this issue Apr 22, 2020 · 0 comments · Fixed by #3488
Closed

[spanner] bug: sample code is waiting for the backup operations forever. #3471

tmatsuo opened this issue Apr 22, 2020 · 0 comments · Fixed by #3488
Assignees
@tmatsuo
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 22, 2020

Example:

python-docs-samples/spanner/cloud-client/backup_sample.py

Line 45 in 75522dc

operation.result()

We should set a hard deadline.
@tmatsuo tmatsuo added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: spanner Issues related to the Spanner API. labels Apr 22, 2020
@tmatsuo tmatsuo mentioned this issue Apr 22, 2020
Merged
@tmatsuo tmatsuo assigned tmatsuo and unassigned gguuss Apr 23, 2020
tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Apr 23, 2020
[spanner] fix: set timeout for polling on operations
46051ae 
fixes GoogleCloudPlatform#3471
@tmatsuo tmatsuo mentioned this issue Apr 23, 2020
Merged
tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Apr 24, 2020
[spanner] fix: set timeout for polling on operations
9277283 
fixes GoogleCloudPlatform#3471
tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Apr 24, 2020
[spanner] fix: set timeout for polling on operations
ce52820 
fixes GoogleCloudPlatform#3471
tmatsuo pushed a commit that referenced this issue Apr 25, 2020
[spanner] fix: set timeout for polling on operations (#3488)
1e072f2 
* [spanner] fix: set timeout for polling on operations

fixes #3471

* bump the deadline to 1200 for backup and restore

* bumped the deadline to 120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmatsuo tmatsuo

Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[spanner] fix: set timeout for polling on operations tmatsuo/python-docs-samples
2 participants
@tmatsuo @gguuss