Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add monitoring resources #714

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

alaincormier-ssc
Copy link
Collaborator

address #713 for core-landing-zone
(documentation and experimentation in future PR)

  • add monitoring resources and permissions
  • move storage.admin role for logging namespace service account to logging.yaml

fmichaelobrien
fmichaelobrien previously approved these changes Nov 22, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cartyc
cartyc previously approved these changes Nov 22, 2023
lucstjean-ssc
lucstjean-ssc previously approved these changes Nov 22, 2023
Copy link
Collaborator

@lucstjean-ssc lucstjean-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alaincormier-ssc alaincormier-ssc merged commit 14964df into main Nov 23, 2023
3 checks passed
@alaincormier-ssc alaincormier-ssc deleted the gh713-feat-monitoring branch November 23, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants