-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add monitoring resources #714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaincormier-ssc
requested review from
lucstjean-ssc,
davelanglois-ssc,
stephanemillaire-ssc,
anoopsidhu-ssc and
borkodjurkovic-ssc
November 22, 2023 19:00
alaincormier-ssc
requested review from
cartyc and
fmichaelobrien
as code owners
November 22, 2023 19:00
fmichaelobrien
previously approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cartyc
previously approved these changes
Nov 22, 2023
lucstjean-ssc
previously approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…other permissions
alaincormier-ssc
dismissed stale reviews from lucstjean-ssc, cartyc, and fmichaelobrien
via
November 23, 2023 11:54
45c9e68
alaincormier-ssc
requested review from
davelanglois-ssc,
cartyc,
lucstjean-ssc and
fmichaelobrien
November 23, 2023 12:00
davelanglois-ssc
approved these changes
Nov 23, 2023
fmichaelobrien
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #713 for core-landing-zone
(documentation and experimentation in future PR)