Skip to content

Commit

Permalink
fix: adding a setters for client-folder-display-name into the experim…
Browse files Browse the repository at this point in the history
…entation/client-landing-zone package (#898)

adding a setters for client-folder-display-name into the experimentation/client-landing-zone package
  • Loading branch information
davelanglois-ssc authored Mar 13, 2024
1 parent 15bf768 commit ee1e954
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
15 changes: 8 additions & 7 deletions solutions/experimentation/client-landing-zone/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ Package to create a client's folder hierarchy and logging resources.

## Setters

| Name | Value | Type | Count |
|--------------------------|---------------------------|------|-------|
| client-folderviewer | group:client1@example.com | str | 1 |
| client-name | client1 | str | 13 |
| logging-project-id | logging-project-12345 | str | 4 |
| retention-in-days | 1 | int | 1 |
| retention-locking-policy | false | bool | 1 |
| Name | Value | Type | Count |
|----------------------------|----------------------------|------|-------|
| client-folder-display-name | client-folder-display-name | str | 1 |
| client-folderviewer | group:client1@example.com | str | 1 |
| client-name | client1 | str | 12 |
| logging-project-id | logging-project-12345 | str | 4 |
| retention-in-days | 1 | int | 1 |
| retention-locking-policy | false | bool | 1 |

## Sub-packages

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ metadata:
name: clients.client-name # kpt-set: clients.${client-name}
namespace: hierarchy
spec:
displayName: client-name # kpt-set: ${client-name}
displayName: client-folder-display-name # kpt-set: ${client-folder-display-name}
folderRef:
name: clients
4 changes: 4 additions & 0 deletions solutions/experimentation/client-landing-zone/setters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ data:
# customization: required
client-name: 'client1'
#
# Client folder display name
# customization: required
client-folder-display-name: client-folder-display-name
#
# group to grant viewer permission on client folder
# customization: required
client-folderviewer: 'group:client1@example.com'
Expand Down

0 comments on commit ee1e954

Please sign in to comment.