Upgrade to a /v2 module and bump deps #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
commented
Nov 26, 2024
|
|
||
| go 1.16 | ||
| go 1.21 |
There was a problem hiding this comment.
This is bumped because the minimum supported version in Go protobuf is v1.21
https://github.com/protocolbuffers/protobuf-go/blob/v1.35.2/go.mod#L3
|
This is the type of errors users will see: |
|
Looks good now, And the docs are correct https://pkg.go.dev/github.com/GoogleCloudPlatform/protoc-gen-bq-schema/v2 |
|
Thanks Michael! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tagging a v2, we should also update the Go module itself to a /v2 by suffixing.
Also updated the dependencies.
You should be able to merge this, tag a
v2.0.1and then users will be able to correctlygo install ...