fix: Issue 1312 incorrect status code #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocessing multiple files - test suite to be updated.
|
/gcbrun |
|
/gcbrun |
nj1973
reviewed
Nov 7, 2024
helensilva14
reviewed
Nov 7, 2024
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
helensilva14
pushed a commit
that referenced
this pull request
Jan 20, 2025
* Updated so that when execptions are raised, they are re-raised when processing multiple files - test suite to be updated. * Test to test exceptions were raised after validating multiple files * Linted * Removed extraneous comment * Updated based on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes the issue that DVT returns status code (0) even if there is an exception while validating the yaml file. This results in Cloud Run considering the validation a success even when there is a transient error such as writing to BigQuery.
The issue Error handling for --config-dir YAMLs was raised. The issue is that when customers are validating multiple yaml files in a directory, customers had to fix one yaml at a time. When one yaml failed validation and raised an exception, the rest of the yaml files were not processed. This was fixed in PR605. The fix was to catch exceptions raised, throw an error and skip to processing the next file. However, the exception raised in processing one of the files was lost. This "losing the exception" happened even if only one yaml file was being processed.
The fix is to move the exception processing logic to where the config runner is processing multiple files, so this behavior is only when multiple files are being processed. A flag is set to signal that one of the files had an exception and an exception is raised after processing all the files. In this way, the status is reported correctly. A config runner unit test has also been added.
Sundar Mudupalli