Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Success status returned when validations in YAML files throw exception #1312

Closed
sundar-mudupalli-work opened this issue Nov 4, 2024 · 0 comments · Fixed by #1317
Closed

Success status returned when validations in YAML files throw exception #1312

sundar-mudupalli-work opened this issue Nov 4, 2024 · 0 comments · Fixed by #1317
Labels
priority: p0 Highest priority. Critical issue. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@sundar-mudupalli-work
Copy link
Collaborator

Hi,

DVT returns success status (i.e. exit (0)) even when the YAML file throws an exception (after printing message "Error %s occurred while running config file %s. Skipping it for now.").

This is problematic when the YAML file is run using Cloud Run and there is an intermittent error (like failure writing to BQ). The expectation is that DVT would return a failure status code (non zero exit status) - which could result in the task being retried.

Sundar Mudupalli
@helensilva14 helensilva14 linked a pull request Nov 7, 2024 that will close this issue
fix: Issue 1312 incorrect status code #1317
Merged
@helensilva14 helensilva14 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p0 Highest priority. Critical issue. Will be fixed prior to next release. labels Nov 10, 2024
@helensilva14 helensilva14 moved this to Ready for Review 💭 in Data Validation Tool Release Tracker Nov 10, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review 💭 to Done 🚀 in Data Validation Tool Release Tracker Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p0 Highest priority. Critical issue. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
Data Validation Tool Release Tracker
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Issue 1312 incorrect status code GoogleCloudPlatform/professional-services-data-validator
2 participants
@helensilva14 @sundar-mudupalli-work