Add transfer Issue plugin to Kubeflow repos #2331

andreyvelich · 2024-07-26T18:23:28Z

I added cherrypicker and transfer issue plugins to the Kubeflow repos:

This should help us with Kubeflow repo migration: kubeflow/kubeflow#7549

Also, added kubeflow/dashboard repo to the Kubeflow list.

/hold for review

/cc @rimolive @terrytangyuan @kimwnasptd @thesuperzapper @StefanoFioravanzo @zijianjoy @johnugeorge @jbottum @james-jwu

google-oss-prow · 2024-07-26T18:23:34Z

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: terrytangyuan, johnugeorge, StefanoFioravanzo, jbottum, rimolive, kimwnasptd, thesuperzapper.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

I added cherrypicker and transfer issue plugins to the Kubeflow repos:

https://prow.k8s.io/command-help#cherrypick

https://prow.k8s.io/command-help#transfer_issue

This should help us with Kubeflow repo migration: kubeflow/kubeflow#7549

Also, added kubeflow/dashboard repo to the Kubeflow list.

/hold for review

/cc @rimolive @terrytangyuan @kimwnasptd @thesuperzapper @StefanoFioravanzo @zijianjoy @johnugeorge @jbottum @james-jwu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

google-oss-prow · 2024-07-26T18:23:45Z

Hi @andreyvelich. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

terrytangyuan

/lgtm

google-oss-prow · 2024-07-26T18:58:22Z

@terrytangyuan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

thesuperzapper · 2024-07-26T21:21:19Z

@andreyvelich we need to ask a googler for review.

We should also set up a policy around which situations warrant a repo transfer for an issue, especially for cases where there is ambiguity.

In cases where things are very ambiguous (technical discussions covering multiple components), I think we should use kubeflow/kubeflow, rather than community or manifests.

And keep those repos for things directly related to their contents.

andreyvelich · 2024-07-29T14:09:35Z

Sure.
/assign @chaodaiG @chases2 @cjwagner @fejta @michelle192837 @mpherman2

google-oss-prow · 2024-07-29T14:09:39Z

@andreyvelich: GitHub didn't allow me to assign the following users: fejta, mpherman2.

Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Sure.
/assign @chaodaiG @chases2 @cjwagner @fejta @michelle192837 @mpherman2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

andreyvelich · 2024-07-29T14:13:26Z

In cases where things are very ambiguous (technical discussions covering multiple components)

Why we can't use kubeflow/manifests for Kubeflow platform questions (cc @juliusvonkohout) or kubeflow/community for the new project adoption and questions for the community direction?
We can always reconsider it in the future, if that won't work for us.

I feel that it will be really hard to triage issues under kubeflow/kubeflow for community members and our users will feel bad about it.

andreyvelich · 2024-07-29T15:43:08Z

Additionally, I added trigger plugin to the Kubeflow: https://prow.k8s.io/command-help#ok_to_test.
That will allow us to add /ok-to-test label to the PRs and trigger GitHub actions with /rerun-all command. Currently, you have to have write access to add this label to the PR.

We already use this GitHub action in several repos (Pipelines, Katib, Training Operator) to re-trigger GitHub actions using PR comments: https://github.com/estroz/rerun-actions.
This actions expect ok-to-test label to be present.

cc @rimolive

cjwagner · 2024-07-29T16:49:01Z

/test all
/approve

andreyvelich · 2024-07-29T17:10:37Z

/retest

google-oss-prow · 2024-07-29T17:11:07Z

@andreyvelich: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cjwagner · 2024-07-29T21:50:23Z

/ok-to-test

rimolive · 2024-07-30T15:27:10Z

I'm good with the changes.

andreyvelich · 2024-07-30T15:29:30Z

@thesuperzapper Do you know if I setup the cherrypicker plugin correctly ?
I just follow the same config as for Kubernetes prow: https://github.com/kubernetes/test-infra/blob/ab0aea453361484ad834f42c7cb633f5f74a3535/config/prow/plugins.yaml#L1826.

andreyvelich · 2024-08-07T13:01:09Z

@rimolive @terrytangyuan @kimwnasptd @thesuperzapper @StefanoFioravanzo @zijianjoy @johnugeorge @jbottum @james-jwu Anything you want to add before merging this PR ?

rimolive · 2024-08-07T15:03:06Z

No other things to add. Thanks @andreyvelich for working in this PR.

andreyvelich · 2024-08-08T12:14:20Z

@zijianjoy @chensun @james-jwu @chaodaiG @chases2 @cjwagner @fejta @michelle192837 @mpherman2 Please can you help us to LGTM this PR ?

andreyvelich · 2024-08-08T12:14:27Z

/hold cancel

cjwagner

I'm not sure how much work it would take to set up the cherrypicker external-plugin for this Prow instance. If that is something you would like can you please open a separate GitHub issue requesting that?

If you remove the external_plugins section for now I can approve the rest of this PR though.

cjwagner · 2024-08-08T19:11:49Z

prow/oss/plugins.yaml

+    events:
+    - issue_comment
+    - pull_request
+    endpoint: http://cherrypicker


There is no cherrypicker service deployed on this Prow instance so there won't be anything to reach at this endpoint.

I see, thanks for checking @cjwagner! I will create separate issue and remove it from this PR.

I tested it with kubeflow/manifests#2837 (comment) and it worked out fine.

Amazing, thank you @juliusvonkohout!

google-oss-prow · 2024-08-08T19:31:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, cjwagner, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cjwagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2024-08-08T19:34:39Z

@andreyvelich: Updated the plugins configmap in namespace default at cluster default using the following files:

key plugins.yaml using file prow/oss/plugins.yaml

In response to this:

I added cherrypicker and transfer issue plugins to the Kubeflow repos:

https://prow.k8s.io/command-help#cherrypick

https://prow.k8s.io/command-help#transfer_issue

This should help us with Kubeflow repo migration: kubeflow/kubeflow#7549

Also, added kubeflow/dashboard repo to the Kubeflow list.

/hold for review

/cc @rimolive @terrytangyuan @kimwnasptd @thesuperzapper @StefanoFioravanzo @zijianjoy @johnugeorge @jbottum @james-jwu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hbelmiro · 2024-08-13T16:00:20Z

prow/oss/plugins.yaml

@@ -338,33 +341,11 @@ plugins:
    - project # Lets issues be tagged into projects
    - size
    - skip  # Allows cleaning up stale commit statuses
+    - transfer-issue # Transfer issue to a different repo in the same org.
+    - trigger # Enable /ok-to-test command to trigger GitHub actions with /rerun-all


@andreyvelich if my understanding is correct, /ok-to-test should trigger GitHub Actions after this change. But it didn't.

Do you know if there's anything else that we should do, or is that a bug?

cc @rimolive @DharmitD

@hbelmiro This plugin just adds ok-to-test label to the PR after we add this comment: /ok-to-test.
It doesn't trigger the GitHub actions.
Since we use this action to trigger our action: https://github.com/estroz/rerun-actions, you need to add this comment to trigger the actions:

/rerun-all

I see.
The comment made me think that /ok-to-test would somehow automatically trigger /rerun-all.
Thank you @andreyvelich.

Add Cherrypicker and Transfer Issue plugins to Kubeflow repos

d788cf3

google-oss-prow bot added the do-not-merge/hold label Jul 26, 2024

google-oss-prow bot requested review from james-jwu and zijianjoy July 26, 2024 18:23

google-oss-prow bot added size/XS needs-ok-to-test labels Jul 26, 2024

terrytangyuan approved these changes Jul 26, 2024

View reviewed changes

google-oss-prow bot assigned chaodaiG, chases2, cjwagner and michelle192837 Jul 29, 2024

google-oss-prow bot added the approved label Jul 29, 2024

Add trigger plugin

a0e3036

andreyvelich force-pushed the update-kubeflow-plugins branch from 62b40c3 to a0e3036 Compare July 29, 2024 17:08

google-oss-prow bot added size/S and removed size/XS labels Jul 29, 2024

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Jul 29, 2024

Move cherrypicker to the external_plugins

b12eb39

google-oss-prow bot added size/M and removed size/S labels Jul 30, 2024

Add lifecycle/needs-triage label into additional_labels

d4d2876

google-oss-prow bot removed the do-not-merge/hold label Aug 8, 2024

cjwagner requested changes Aug 8, 2024

View reviewed changes

google-oss-prow bot removed the approved label Aug 8, 2024

Remove Cherrypicker plugin

5fa2c0c

google-oss-prow bot added size/S and removed size/M labels Aug 8, 2024

andreyvelich mentioned this pull request Aug 8, 2024

Enable endpoint for cherrypicker plugin #2343

Closed

andreyvelich changed the title ~~Add cherrypicker and transfer Issue plugins to Kubeflow repos~~ Add transfer Issue plugins to Kubeflow repos Aug 8, 2024

andreyvelich changed the title ~~Add transfer Issue plugins to Kubeflow repos~~ Add transfer Issue plugin to Kubeflow repos Aug 8, 2024

cjwagner approved these changes Aug 8, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Aug 8, 2024

google-oss-prow bot added the approved label Aug 8, 2024

google-oss-prow bot merged commit 0015432 into GoogleCloudPlatform:master Aug 8, 2024
5 checks passed

andreyvelich deleted the update-kubeflow-plugins branch August 9, 2024 10:03

hbelmiro reviewed Aug 13, 2024

View reviewed changes

andreyvelich mentioned this pull request Aug 13, 2024

[TRACKING] discussion & planning for future of kubeflow/kubeflow repo kubeflow/kubeflow#7549

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add transfer Issue plugin to Kubeflow repos #2331

Add transfer Issue plugin to Kubeflow repos #2331

andreyvelich commented Jul 26, 2024

google-oss-prow bot commented Jul 26, 2024

google-oss-prow bot commented Jul 26, 2024

terrytangyuan left a comment

google-oss-prow bot commented Jul 26, 2024

thesuperzapper commented Jul 26, 2024

andreyvelich commented Jul 29, 2024

google-oss-prow bot commented Jul 29, 2024

andreyvelich commented Jul 29, 2024

andreyvelich commented Jul 29, 2024

cjwagner commented Jul 29, 2024

andreyvelich commented Jul 29, 2024

google-oss-prow bot commented Jul 29, 2024

cjwagner commented Jul 29, 2024

rimolive commented Jul 30, 2024

andreyvelich commented Jul 30, 2024

andreyvelich commented Aug 7, 2024

rimolive commented Aug 7, 2024

andreyvelich commented Aug 8, 2024

andreyvelich commented Aug 8, 2024

cjwagner left a comment

cjwagner Aug 8, 2024

andreyvelich Aug 8, 2024

juliusvonkohout Aug 9, 2024

andreyvelich Aug 9, 2024

google-oss-prow bot commented Aug 8, 2024

google-oss-prow bot commented Aug 8, 2024

hbelmiro Aug 13, 2024 •

edited

Loading

andreyvelich Aug 13, 2024 •

edited

Loading

hbelmiro Aug 13, 2024

Add transfer Issue plugin to Kubeflow repos #2331

Add transfer Issue plugin to Kubeflow repos #2331

Conversation

andreyvelich commented Jul 26, 2024

google-oss-prow bot commented Jul 26, 2024

google-oss-prow bot commented Jul 26, 2024

terrytangyuan left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Jul 26, 2024

thesuperzapper commented Jul 26, 2024

andreyvelich commented Jul 29, 2024

google-oss-prow bot commented Jul 29, 2024

andreyvelich commented Jul 29, 2024

andreyvelich commented Jul 29, 2024

cjwagner commented Jul 29, 2024

andreyvelich commented Jul 29, 2024

google-oss-prow bot commented Jul 29, 2024

cjwagner commented Jul 29, 2024

rimolive commented Jul 30, 2024

andreyvelich commented Jul 30, 2024

andreyvelich commented Aug 7, 2024

rimolive commented Aug 7, 2024

andreyvelich commented Aug 8, 2024

andreyvelich commented Aug 8, 2024

cjwagner left a comment

Choose a reason for hiding this comment

cjwagner Aug 8, 2024

Choose a reason for hiding this comment

andreyvelich Aug 8, 2024

Choose a reason for hiding this comment

juliusvonkohout Aug 9, 2024

Choose a reason for hiding this comment

andreyvelich Aug 9, 2024

Choose a reason for hiding this comment

google-oss-prow bot commented Aug 8, 2024

google-oss-prow bot commented Aug 8, 2024

hbelmiro Aug 13, 2024 • edited Loading

Choose a reason for hiding this comment

andreyvelich Aug 13, 2024 • edited Loading

Choose a reason for hiding this comment

hbelmiro Aug 13, 2024

Choose a reason for hiding this comment

hbelmiro Aug 13, 2024 •

edited

Loading

andreyvelich Aug 13, 2024 •

edited

Loading