Update OTLPMetric test to latest OTel SDK #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferbrecht
requested review from
a team and
franciscovalentecastro
and removed request for
a team
franciscovalentecastro
approved these changes
Jan 30, 2023
| @@ -64,13 +63,14 @@ func main() { | |||
| } | |||
|
|
|||
| func testGaugeMetric(meter metric.Meter, name string) { | |||
| gauge, err := meter.AsyncFloat64().Gauge(name) | |||
| gauge, err := meter.Float64ObservableGauge(name) | |||
There was a problem hiding this comment.
What's the difference between the previous Async / Sync to the current methods ?
There was a problem hiding this comment.
AFAICT they've just been renamed -- Sync is now omitted from the name and Async instruments are now Observable.
|
Optional : Change the name of the PR or commit when merged, so it mentions it's only an update in the |
jefferbrecht
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context: open-telemetry/opentelemetry-go#3575
Related issue
b/267152693
How has this been tested?
Tested the new metrics.go standalone until it worked; will let the presubmits run the actual integration test.
Checklist: