Update OTLP auth example #803
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
- Coverage 60.80% 60.73% -0.08%
==========================================
Files 56 56
Lines 5649 5649
==========================================
- Hits 3435 3431 -4
- Misses 2066 2070 +4
Partials 148 148 ☔ View full report in Codecov by Sentry. |
damemi
force-pushed
the
update-otlp-auth-sample
branch
from
0f22764
to
bf8e8ad
Compare
damemi
force-pushed
the
update-otlp-auth-sample
branch
from
bf8e8ad
to
341dc95
Compare
damemi
force-pushed
the
update-otlp-auth-sample
branch
from
341dc95
to
2f416c2
Compare
|
Updated this to add an http sample too, going to merge if everything is green |
example/trace/otlpgrpc/example.go
Outdated
| res := resource.NewWithAttributes(semconv.SchemaURL, attribute.String("gcp.project_id", projectID)) | ||
|
|
||
| // set endpoint with OTEL_EXPORTER_OTLP_ENDPOINT=https://<endpoint> | ||
| exporter, err := otlptracegrpc.New(ctx, otlptracegrpc.WithDialOption(grpc.WithPerRPCCredentials(creds)), otlptracegrpc.WithHeaders(map[string]string{"x-goog-user-project": projectID})) |
There was a problem hiding this comment.
Should we tell users to use OTEL_EXPORTER_OTLP_HEADERS instead?
There was a problem hiding this comment.
Yeah, using the env vars should be fine. One thing though is the Authorization header in the http example. You could do something like set it in the env var with Authorization: Bearer $(gcloud auth print-access-token) but I think getting that programmatically is probably better. What do you think?
There was a problem hiding this comment.
we will still need to get credentials programmatically.
There was a problem hiding this comment.
This took some digging, but it looks like WithHeaders overwrites OTEL_EXPORTER_OTLP_HEADERS (couldn't find docs but I found a test asserting it, and I couldn't get it to work with both)
So if we pass Authorization using WithHeaders, we also need the other headers that way too. Unless they can be merged somehow
Add
x-goog-user-projectheader and setgcp.project_id(not sure if that needs to be a span attribute or resource attribute, so I'm setting both for now)Repro steps:
gcloud auth application-default loginexport OTEL_EXPORTER_OTLP_ENDPOINT=otlp://<endpoint>export GCLOUD_PROJECT=<project id>go run example.go