Update OTel dependencies #721
Conversation
…perations-go into otel-1.18.0
| @@ -49,6 +49,7 @@ tools: $(GOLANGCI_LINT) $(MISSPELL) $(GOCOVMERGE) $(STRINGER) $(GOJQ) $(FIELDALI | |||
|
|
|||
| PROTOBUF_VERSION = 3.19.0 | |||
| PROTOBUF_OS = linux | |||
| UNAME_S := $(shell uname -s) | |||
There was a problem hiding this comment.
I noticed protoc wasn't working on my mac as this variable wasn't actually set to anything, I believe it was removed with some cleanup at some point. It could be nice to run the entire CI on multiple machines to ensure it continues to build on them, though the notable step is this one I think
| desc: "sum without total is unaffected when normalization disabled", | ||
| baseName: "foo", | ||
| metric: func(m pmetric.Metric) { | ||
| //nolint:errcheck |
There was a problem hiding this comment.
The default for this feature gate changed, I tried to preserve tests with and without the change
| @@ -238,6 +278,10 @@ func TestGetMetricName(t *testing.T) { | |||
| }, | |||
| } { | |||
| t.Run(tc.desc, func(t *testing.T) { | |||
| // Name translation uses global feature gate registry, set to defaults before each test. | |||
There was a problem hiding this comment.
This was missing before but seems to be important
| @@ -307,7 +307,7 @@ func TestHistogramPointToTimeSeries(t *testing.T) { | |||
| hdp := ts.Points[0].Value.GetDistributionValue() | |||
| assert.Equal(t, int64(15), hdp.Count) | |||
| assert.ElementsMatch(t, []int64{1, 2, 3, 4, 5}, hdp.BucketCounts) | |||
| assert.Equal(t, 12847.600000000002, hdp.SumOfSquaredDeviation) | |||
| assert.InDelta(t, 12847.6, hdp.SumOfSquaredDeviation, 0.0001) | |||
There was a problem hiding this comment.
Was failing for me on M1, I think this is an appropriate way of asserting on a floating point number that is going through rounding
| @@ -155,7 +154,7 @@ func (me *metricExporter) Temporality(ik metric.InstrumentKind) metricdata.Tempo | |||
| } | |||
|
|
|||
| // Aggregation returns the Aggregation to use for an instrument kind. | |||
| func (me *metricExporter) Aggregation(ik metric.InstrumentKind) aggregation.Aggregation { | |||
| func (me *metricExporter) Aggregation(ik metric.InstrumentKind) metric.Aggregation { | |||
There was a problem hiding this comment.
This is the only non-test change to work with the new version of the SDK
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
==========================================
- Coverage 69.58% 69.50% -0.09%
==========================================
Files 42 42
Lines 4840 4840
==========================================
- Hits 3368 3364 -4
- Misses 1321 1325 +4
Partials 151 151
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/gcbrun |
Fixes #719