-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from multierr.Combine to errors.Join and update go version #708
Conversation
Codecov Report
@@ Coverage Diff @@
## main #708 +/- ##
==========================================
+ Coverage 69.39% 69.59% +0.20%
==========================================
Files 36 36
Lines 4735 4717 -18
==========================================
- Hits 3286 3283 -3
+ Misses 1298 1286 -12
+ Partials 151 148 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you can get the tests to pass
I'm going to update the go version (errors.Join was added in 1.20). We support the latest 2 versions, so that should be OK |
Hi @dashpole - it looks like this was merged and released with |
@anuraaga I went ahead and updated to 1.21, since we support the latest 2 versions of go. Did this cause issues for you? |
I saw a warning when compiling with 1.20, not sure if there was something special about my build setup. But AFAIK the intent of that flag is for libraries to always set the version in go.mod to the minimum supported so the Go compiler prevents as much as possible incompatibilities when compiling with the older version. |
Fixes #704
This also updates the go version support window from [1.19,1.20] to [1.20,1.21].
From the definition of errors.Join: