Remove GMP factory functions and readme #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
force-pushed
the
remove-gmp-exporter-factory
branch
from
2f716b8
to
6a1e0a3
Compare
damemi
commented
Jul 8, 2022
| @@ -600,74 +600,6 @@ | |||
| } | |||
| ], | |||
| "createMetricDescriptorRequests": [ | |||
| { | |||
| "name": "projects/myproject", | |||
There was a problem hiding this comment.
cc @dashpole (when you're back) these fixture updates look weird to me, not sure if this is expected or I removed too much code from here. either way can you ptal and confirm?
There was a problem hiding this comment.
See #342 (comment). The fixture changes here are the reverse of the fixture changes in the PR that added the GMP exporter, and exist because we no longer import exporterhelper.
dashpole
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the GMP exporter available in the contrib repo and distribution, the config and factory code is no longer needed here. Users can now build/use directly from collector-contrib, so the README (which only had instructions on how to build it yourself) is also removed. Other files are kept as they contain the functions used by the exporter