Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocgrpc self-obs metrics in test fixtures #281

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Jan 19, 2022

  • Enable the ocgrpc views in integration tests
  • Some of the ocgrpc metrics like latency and byte sizes are not reproducible across test runs, so we normalize the values away but still check the type and label sets of these metrics. This will still capture histogram bucket boundaries and value types.
  • Update the value field to a oneof with a slimmed down Histogram option.
  • Added a metric type field to the fixture which should be roughly what would be sent to GCM for the metric.

@aabmass aabmass changed the base branch from main to col-exporter-rewrite January 19, 2022 20:39
@aabmass aabmass changed the title ocgrpc self obs fix Normalize unreproducible ocgrpc self-obs metrics in test fixtures Jan 19, 2022
@aabmass aabmass force-pushed the ocgrpc-self-obs-fix branch from 7357748 to 35d03e9 Compare January 19, 2022 20:56
@aabmass aabmass changed the title Normalize unreproducible ocgrpc self-obs metrics in test fixtures Add ocgrpc self-obs metrics in test fixtures Jan 19, 2022
@aabmass aabmass force-pushed the ocgrpc-self-obs-fix branch 2 times, most recently from 99049b2 to 3ba7a17 Compare January 19, 2022 22:18
@aabmass aabmass force-pushed the ocgrpc-self-obs-fix branch from 3ba7a17 to a9c04f8 Compare January 19, 2022 22:27
@aabmass aabmass closed this Jan 20, 2022
@aabmass aabmass deleted the ocgrpc-self-obs-fix branch January 20, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant