Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable ops-agent self-metric integration test. #260

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Re-enable ops-agent self-metric integration test. #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion exporter/collector/internal/integrationtest/testcases.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,12 @@ var (
Name: "Ops Agent Self-Reported metrics",
OTLPInputFixturePath: "testdata/fixtures/ops_agent_self_metrics.json",
ExpectFixturePath: "testdata/fixtures/ops_agent_self_metrics_expect.json",
Skip: true,
Skip: false,
Configure: func(cfg *collector.Config) {
// Previous exporter did NOT export metric descriptors.
// TODO: Add a new test that also checks metric descriptors.
cfg.MetricConfig.SkipCreateMetricDescriptor = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be using CreateServiceTimeSeries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a separate question. It was not, when this test was recorded :)

},
},
{
Name: "Ops Agent Host Metrics",
Expand Down