Skip to content

Commit

Permalink
fixup! Update OTEL dependencies to latest release candidates
Browse files Browse the repository at this point in the history
  • Loading branch information
lrascao committed May 25, 2023
1 parent bad0d26 commit f14e232
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions exporter/collector/integrationtest/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package integrationtest

import (
"context"
"fmt"
"sort"
"testing"
"time"
Expand Down Expand Up @@ -204,11 +203,10 @@ func TestSDKMetrics(t *testing.T) {
expectFixture,
)
if diff != "" {
fmt.Printf("%s", diff)
require.Fail(
t,
"Expected requests fixture and actual GCM requests differ",
"",
diff,
)
}
})
Expand Down
2 changes: 1 addition & 1 deletion exporter/metric/metric.go
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ func recordToMdpbKindType(a metricdata.Aggregation) (googlemetricpb.MetricDescri
return googlemetricpb.MetricDescriptor_CUMULATIVE, googlemetricpb.MetricDescriptor_DOUBLE
}
return googlemetricpb.MetricDescriptor_GAUGE, googlemetricpb.MetricDescriptor_DOUBLE
case metricdata.Histogram[float64]:
case metricdata.Histogram[int64], metricdata.Histogram[float64]:
return googlemetricpb.MetricDescriptor_CUMULATIVE, googlemetricpb.MetricDescriptor_DISTRIBUTION
default:
return googlemetricpb.MetricDescriptor_METRIC_KIND_UNSPECIFIED, googlemetricpb.MetricDescriptor_VALUE_TYPE_UNSPECIFIED
Expand Down

0 comments on commit f14e232

Please sign in to comment.