Re-enable workload metrics integration tests

GoogleCloudPlatform · Jan 27, 2022 · 54d87a7 · 54d87a7
1 parent 9b5f9a8
commit 54d87a7
Show file tree

Hide file tree

Showing 5 changed files with 5,813 additions and 5,610 deletions.
diff --git a/exporter/collector/breaking-changes.md b/exporter/collector/breaking-changes.md
@@ -13,6 +13,11 @@ Additionally, the previous exporter had a hardcoded list of known metric domains
 where this "prefix" would not be used. The new exporter allows full configuration
 of this list via the `metric.known_domains` property.
 
+The previous exporter would by default only call CreateMetricDescriptor for metrics with domain
+`custom.googleapis.com` or `external.googleapis.com`. The new exporter will try to call
+CreateMetricDescriptor regardless of domain, unless `metric.skip_create_descriptor` or
+`metric.create_service_timeseries` are true.
+
 Additionally, the DisplayName for a metric used to be exactly the
 `{metric_name}`. Now, the metric name is chosen as the full-path after the
 domain name of the metric type.  E.g. if a metric called

diff --git a/exporter/collector/integrationtest/testcases.go b/exporter/collector/integrationtest/testcases.go
@@ -83,9 +83,9 @@ var (
 			Name:                 "GKE Workload Metrics",
 			OTLPInputFixturePath: "testdata/fixtures/workload_metrics.json",
 			ExpectFixturePath:    "testdata/fixtures/workload_metrics_expect.json",
-			Skip:                 true,
 			Configure: func(cfg *collector.Config) {
 				cfg.MetricConfig.Prefix = "workload.googleapis.com/"
+				cfg.MetricConfig.SkipCreateMetricDescriptor = true
 			},
 		},
 		{