Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monitoring Tests #85

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Add Monitoring Tests #85

merged 1 commit into from
Mar 30, 2016

Conversation

waprin
Copy link
Contributor

@waprin waprin commented Mar 21, 2016

@JustinBeckwith @jonparrott

Unfortunately we have to code freeze these samples until GCP Next is over next week, but feel free to review at your convenience.

Had to refactor the main code a bit, since for my custom metric tests, I generate a new custom metric and write one value for it. I made CustomMetrics a class so I could attach the metric name to its state. Not sure if this the most idiomatic way to do it for this repo so let me know.

The tests aren't going to work until the API no longer requires a whitelist. That might be now or very soon (I'll double check), otherwise we can add your test project as an owner of mine.

@jmdobry
Copy link
Member

jmdobry commented Mar 30, 2016

Hmm, the test is failing, says google.monitoring is not a function. I can see that it's using google-api-nodejs-client 3.1.0, which should support the monitoring API. Clearing the Travis cache and trying again...

@jmdobry
Copy link
Member

jmdobry commented Mar 30, 2016

I figured it out.

@jmdobry jmdobry changed the title [DO NOT MERGE] Add Monitoring Tests Add Monitoring Tests Mar 30, 2016
@jmdobry jmdobry merged commit 29bf77a into master Mar 30, 2016
@jmdobry jmdobry deleted the monitoringtests branch March 30, 2016 22:15
sethbergman pushed a commit to stackriot/nodejs-docs-samples that referenced this pull request Jun 4, 2017
* First draft of ES6 upgrade

* Fix nits

* Get tests passing + fix more stuff

* Upgrade package.json engine to 4.3.2
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
ace-n pushed a commit that referenced this pull request Nov 21, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
jsimonweb pushed a commit to jsimonweb/nodejs-docs-samples that referenced this pull request Dec 12, 2022
irataxy pushed a commit that referenced this pull request Jan 14, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: bcoe <bencoe@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
irataxy pushed a commit that referenced this pull request Jan 18, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: bcoe <bencoe@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants